fix: address CodeRabbit findings from the v0.2.14 release review (#205)#209
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @w7-mgfcode, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
Addresses the 32 valid CodeRabbit findings from the v0.2.14 release review (#201), tracked in #205. One commit per theme.
Closes #205.
Themes
dimensions/jobs/registrylist endpointsfix(api)TEST-%rows,pop(get_db)overclear(), restore mutatedSettingssingleton infinallytest(api)lib/url-params.ts(parsePageParam/parseIdParam/parseEnumParam) applied acrosssales/runs/stores/products/jobsfix(ui)mutateAsyncin try/catch + surface a toastfix(ui)styleinstead of a non-discoverableh-[${height}px]classfix(ui)tabIndex/role/onKeyDownon clickable rows and sort headers;getVisibleLeafColumns()for skeleton/emptycolSpanfix(ui)Math.ceilreorder qty; pick latest inventory snapshot bydatefix(ui)validate_date_rangeraisesBadRequestErrorso all three analytics endpoints emitapplication/problem+json;ge=1onstore_id/product_idfix(analytics)=/+/-/@/control-char-leading values inquoteFieldfix(ui)Array.isArrayguard on forecast results, config-error state on the Agent Guide, backtest formn_splits>=2/test_size>=1,use-inventorybarrel re-export, shareddefault_seed_end_date()inrun_demo.pyfix(ui)/fix(data)Tests
New regression tests:
url-params.test.ts, CSV-injection + demand-rounding/inventory-by-date cases.Validation
ruff check/ruff format --check— passmypy --strict/pyright --strict— pass (0 errors)pytest -m "not integration"— 1105 passedpytest -m integration(analytics/dimensions/jobs/config) — 30 passedpnpm tsc --noEmit/pnpm lint(0 errors) /pnpm test— 54 passed